fix(rewards): validate denom in FundCommunityPool - #362
Conversation
FundCommunityPool accepted any coin denom at the keeper level. The check only existed in MsgFundPool. If called directly (wasm binding, future module), a wrong-denom deposit corrupts the single-denom CommunityPool invariant and causes future bank sends to fail. Fix: read module params and reject coins with wrong denom before transfer.
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Bug:
Keeper.FundCommunityPoolaccepted any coin denom at the keeper level — the denom check only existed in theMsgFundPoolhandler. IfFundCommunityPoolis called directly (e.g. from a wasm contract binding or future module integration), a wrong-denom deposit would add a foreign coin toCommunityPool, breaking the single-denom invariant. SubsequentBeginBlockercalls would fail the bank send and halt the chain.Fix: Read module params inside
FundCommunityPooland reject coins whose denom does not matchTokenDenombefore transferring funds.Files changed
x/rewards/keeper/keeper.go