feat(ci): bwrap sandbox wrapper for pnpm install (Linux runners) - #14430
Draft
h0lybyte wants to merge 1 commit into
Draft
feat(ci): bwrap sandbox wrapper for pnpm install (Linux runners)#14430h0lybyte wants to merge 1 commit into
h0lybyte wants to merge 1 commit into
Conversation
Confines pnpm install to workspace + store (RO-root), tmpfs's $HOME to hide credentials, and scrubs secret env (--clearenv + allowlist) so a compromised postinstall cannot read $GITHUB_TOKEN / registry tokens. Linux-only; macOS = passthrough. Not yet wired into any workflow (needs bubblewrap in the runner image). Refs #14423.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14423.
Adds
scripts/ci/bwrap-pnpm.sh— a bubblewrap sandbox wrapper forpnpm installon Linux CI runners.What it does
--clearenv+ an allowlist, so a compromised lifecycle/build script cannot read$GITHUB_TOKEN, registry tokens, or other CI secrets.$HOMEis tmpfs'd to hide~/.ssh/~/.aws/~/.npmrcauth.BWRAP_KEEP_ENVescape hatch for a private-registry token if ever needed.Not wired in yet — intentional
This PR only adds the script. It is not referenced by any workflow, so it changes nothing at runtime. Two blockers before wiring (tracked in #14423):
bubblewrapmust be in the ARC/KubeVirt runner image — and ARC pods usually block unprivileged userns, so it needs a setuidbwrapor asecurityContextchange.utils-nx-kbve-shell.ymlto./scripts/ci/bwrap-pnpm.sh install --frozen-lockfile.Verification
bash -n+shellcheckclean.