Skip to content

[draft] fix: keep all build job pods for 24h #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vigneshrajsb wants to merge 2 commits into from
Closed

[draft] fix: keep all build job pods for 24h #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f74dd4
Keep failed build and helm job pods for 24 hours
vigneshrajsb Oct 30, 2025
ead88f8
Update tests to reflect 24h TTL for all build jobs
vigneshrajsb Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/server/lib/kubernetes/jobFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ export interface BuildJobConfig {
}

export function createBuildJob(config: BuildJobConfig): V1Job {
const ttl = config.isStatic ? 86400 : undefined;
// Keep failed pods for 24 hours for debugging purposes
const ttl = 86400;

return createKubernetesJob({
name: config.jobName,
Expand Down Expand Up @@ -172,7 +173,8 @@ export interface HelmJobConfig {
}

export function createHelmJob(config: HelmJobConfig): V1Job {
const ttl = config.isStatic ? 86400 : undefined;
// Keep failed pods for 24 hours for debugging purposes
const ttl = 86400;
const timeout = config.timeout || 1800; // 30 minutes default

const labels: Record<string, string> = {
Expand Down
6 changes: 3 additions & 3 deletions src/server/lib/nativeBuild/__tests__/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ describe('nativeBuild/utils', () => {
expect(manifest.metadata.annotations['lifecycle.io/triggered-at']).toBeDefined();

// Check spec
expect(manifest.spec.ttlSecondsAfterFinished).toBeUndefined(); // No TTL by default for non-static builds
expect(manifest.spec.ttlSecondsAfterFinished).toBe(86400); // 24 hours TTL for all builds
expect(manifest.spec.backoffLimit).toBe(0);
expect(manifest.spec.activeDeadlineSeconds).toBe(1800);

Expand All @@ -92,7 +92,7 @@ describe('nativeBuild/utils', () => {
expect(manifest.spec.template.spec.volumes).toEqual([{ name: 'workspace', emptyDir: {} }]);
});

it('sets TTL for static builds', () => {
it('sets TTL for all builds including static builds', () => {
const options = {
jobName: 'test-job',
namespace: 'test-ns',
Expand All @@ -113,7 +113,7 @@ describe('nativeBuild/utils', () => {
};

const manifest = createBuildJobManifest(options);
expect(manifest.spec.ttlSecondsAfterFinished).toBe(86400); // 24 hours for static builds
expect(manifest.spec.ttlSecondsAfterFinished).toBe(86400); // 24 hours for all builds
});
});
});