[draft] fix: keep all build job pods for 24h - #62
Closed
vigneshrajsb wants to merge 2 commits into
Closed
Conversation
Previously, only static builds retained failed pods for 24 hours (via ttlSecondsAfterFinished). Regular builds had no TTL, causing pods to be deleted immediately after failure, making debugging difficult. This change sets ttlSecondsAfterFinished to 86400 (24 hours) for all build and helm deployment jobs, regardless of the isStatic flag. This gives engineers time to inspect logs, exec into pods, and debug build failures before Kubernetes automatically cleans them up. Related to: Build pod failures with 403 errors from ingress IP whitelist
Updated test expectations to match the new behavior where all build jobs (not just static builds) have a 24-hour TTL for failed pods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.