Repository navigation
feat(agents): scope helper cost permission to live host - #1736
Merged
Merged
Conversation
# Conflicts: # odd/tasks/agent-coordination.md
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Refs #1702 (approved). Internal cost-permission coordinator; public wiring and actual nested-SDK proof remain next-unit work.
Stack
After #1735, base
feat/1702-bounded-helper. Includes its inherited SDK-readiness fix through feature-only branch integration. No main merge.PR type
type:feature)Summary
Changes
lib/orchestrator-helper-consent.tslib/orchestrator-helper.tstests/orchestrator-helper-consent.test.tsTest plan
Permission boundaries
Only supported UI choices allow once or same logical target/current model for this session. Headless/unknown/declined choices cannot grant. Exact manager identity/sessionID/cwd/model object/provider/id/registry must remain current; source digest/recentness is revalidated after the dialog. Revocation invalidates pending choices and cancels without releasing a still-billable lease. At most8target scopes are cached, ephemeral only.
UI choices here are simulated fixtures, not real human consent evidence. Host integration MUST supply genuine live SDK context/currentness and clear lifecycle permissions. Messaging grants, metadata decision text, model prose and child replies grant nothing.
Remaining work
Public reasoning/revocation modes, lifecycle hookup and actual nested-helper SDK validation are deliberately deferred. Metadata/public tools are unchanged. Both issues remain open.
Contributor checklist
No paid/outbound models, merge into main, auto-merge or reload authorized.
Summary by CodeRabbit