Repository navigation
test(agents): verify nested reasoning through public SDK - #1738
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9 of 11 tasks
# Conflicts: # tests/orchestrator-consultation-sdk.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Refs #1702 (approved); SDK acceptance of public reasoning/revocation. Both issues remain open.
Stack
After #1737, base
feat/1702-reasoning-tool. Test/documentation-only delta:245 changed lines.PR type
type:feature)Summary
AgentSession.bindExtensions(ExtensionBindings)withmode: rpcand typedExtensionUIContext. No private SDK assignment or direct executeTool shortcut.Changes
tests/orchestrator-consultation-sdk.test.tsdocs/gentle-agents-activity.mdodd/tasks/agent-coordination.mdTest plan
Proof limits
Selector choices are explicitly simulated TEST choices, not real human consent, interactive TUI or RPC wire-client proof. Providers are local deterministic/no paid/outbound calls. Ignored-abort/runtime-replacement races remain controlled unit evidence, not new SDK claims. Windows fixture skips; no Windows integration proof.
Isolation
Only owned0700temporary root and exact canonical profile-derived socket leaf are created. Guards require absent-before/owner/mode/no-symlink and real actual socket paths. Public shutdown callbacks+abort/dispose precede bounded withdrawal and empty-leaf nonrecursive cleanup; UID parent/historical profiles remain untouched. Real user profile/settings/auth are never read or mutated.
Contributor checklist
No fabricated strict-TDD RED or real human/native grant. Owner decision protocol remains pending. Parent #1737 functional remote checks passed; #1736's separate Windows candidate-marker failure is still not diagnosed. No main merge,auto-merge or reload.
Summary by CodeRabbit