Repository navigation
feat(agents): bound internal read-only helper execution - #1735
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # odd/tasks/agent-coordination.md
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Refs #1702 (approved). Internal execution core only; public reasoning/permission and owner decisions follow later.
Stack
After #1734. Base
test/1702-consultation-sdk. Chain #1714 → #1715 → #1720 → #1724 → #1729 → #1733 → #1734 → this PR.PR type
type:feature)Summary
Changes
lib/orchestrator-helper.tstests/orchestrator-helper.test.tsTest plan
undefined !== busy); GREEN7/7.node scripts/check-types.mjs:186baseline diagnostics,no regressions (not clean compilation); initial4new diagnostics were fixed.node scripts/build-runtime-modules.mjs --check:8modules match;git diff --check.Hard boundaries
16KiB total input including static prompt,1024UTF8B question,512 requested output tokens,4096B returned text,20-second local deadline. Context contains no tools or private history;
toolChoice:none,maxRetries:0. Provider output tool calls are rejected, never executed; thought/error content is not exported. Currentness failure/cancellation discards output; no automatic retries.Abort and token ceilings are SDK requests, not guaranteed remote billing caps. A provider ignoring abort keeps the engine busy until its actual result settles. No timer/late rejection releases the lease prematurely. Usage is numeric-whitelisted, not model-authored permissions.
All output is
helper_advice,ownerReply:false,authority:none, even if model text claims consent. This internal engine grants NO model-cost authorization. Public reasoning is still disabled; next tool integration requires real human UI opt-in. Messaging grants and metadata notes cannot grant that permission.Contributor checklist
No paid/outbound model calls were used in tests. No merge,auto-merge or runtime reload authorized.
Summary by CodeRabbit