Skip to content

fix(CD_preview): ignore production branch in pull request types for deploy preview #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jirhiker merged 1 commit into from
May 20, 2026
Merged

fix(CD_preview): ignore production branch in pull request types for deploy preview #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/CD_preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ name: Preview deploy to Cloud Run

on:
pull_request:
types: [opened, synchronize, reopened, closed]
types: [ opened, synchronize, reopened, closed ]
branches-ignore:
- production
Comment on lines +6 to +7
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle close events for production-targeted PRs

branches-ignore: production on the pull_request trigger suppresses the entire workflow for PRs targeting production, including the closed action. That means the cleanup steps (Remove exact preview origin... / Delete preview on PR close) will never run when a PR that already had a preview is later retargeted to production and then closed, leaving Cloud Run preview services and Authentik redirect URIs orphaned.

Useful? React with 👍 / 👎.


jobs:
deploy-preview:
Expand Down
Loading