Skip to content

fix(CD_preview): ignore production branch in pull request types for deploy preview#280

Merged
jirhiker merged 1 commit into
stagingfrom
branch-preview-ignore-staging-production
May 20, 2026
Merged

fix(CD_preview): ignore production branch in pull request types for deploy preview#280
jirhiker merged 1 commit into
stagingfrom
branch-preview-ignore-staging-production

Conversation

@jirhiker
Copy link
Copy Markdown
Member

@jirhiker jirhiker commented May 20, 2026

no need to do a branch preview when opening a deployment PR to production

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 447d773d56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +6 to +7
branches-ignore:
- production
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle close events for production-targeted PRs

branches-ignore: production on the pull_request trigger suppresses the entire workflow for PRs targeting production, including the closed action. That means the cleanup steps (Remove exact preview origin... / Delete preview on PR close) will never run when a PR that already had a preview is later retargeted to production and then closed, leaving Cloud Run preview services and Authentik redirect URIs orphaned.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-branch-preview-ignore-staging-production-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

@jirhiker jirhiker merged commit 1deb7da into staging May 20, 2026
3 of 4 checks passed
@jirhiker jirhiker deployed to staging May 20, 2026 18:07 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants