fix(CD_preview): ignore production branch in pull request types for deploy preview#280
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 447d773d56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| branches-ignore: | ||
| - production |
There was a problem hiding this comment.
Handle close events for production-targeted PRs
branches-ignore: production on the pull_request trigger suppresses the entire workflow for PRs targeting production, including the closed action. That means the cleanup steps (Remove exact preview origin... / Delete preview on PR close) will never run when a PR that already had a preview is later retargeted to production and then closed, leaving Cloud Run preview services and Authentik redirect URIs orphaned.
Useful? React with 👍 / 👎.
Preview DeploymentPreview URL: https://preview-branch-preview-ignore-staging-production-auejgdbofq-uc.a.run.app Note: This preview uses the staging API endpoints. |
no need to do a branch preview when opening a deployment PR to production