Skip to content

Add support for global and test-local memory overrides#299

Draft
zack-rma wants to merge 1 commit into
mainfrom
bugfix/compute-memory
Draft

Add support for global and test-local memory overrides#299
zack-rma wants to merge 1 commit into
mainfrom
bugfix/compute-memory

Initial memory parser for global and test-local memory overrides

1570e0f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 5, 2026 in 1m 25s

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 214 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make pid a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Ji&open=AZ6aBbChrfn0lGGeP5Ji&pullRequest=299

Check warning on line 81 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make cacheSvar2 a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Hn&open=AZ6aBbChrfn0lGGeP5Hn&pullRequest=299

Check warning on line 140 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static resimDate" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Lf&open=AZ6aBbChrfn0lGGeP5Lf&pullRequest=299

Check warning on line 30 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make currTimeStep a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5G3&open=AZ6aBbChrfn0lGGeP5G3&pullRequest=299

Check warning on line 192 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static t_wt" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5MO&open=AZ6aBbChrfn0lGGeP5MO&pullRequest=299

Check warning on line 66 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make cycleEndMonth a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Hb&open=AZ6aBbChrfn0lGGeP5Hb&pullRequest=299

Check warning on line 100 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static ignoreError" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5K5&open=AZ6aBbChrfn0lGGeP5K5&pullRequest=299

Check warning on line 166 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static monMemSection" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5L0&open=AZ6aBbChrfn0lGGeP5L0&pullRequest=299

Check warning on line 191 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "t_goal" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5M5&open=AZ6aBbChrfn0lGGeP5M5&pullRequest=299

Check warning on line 35 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the type specification in this constructor call with the diamond operator ("<>"). 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Js&open=AZ6aBbChrfn0lGGeP5Js&pullRequest=299

Check warning on line 33 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this member "protected". 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5NQ&open=AZ6aBbChrfn0lGGeP5NQ&pullRequest=299

Check warning on line 158 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make enableProgressLog a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Iu&open=AZ6aBbChrfn0lGGeP5Iu&pullRequest=299

Check warning on line 201 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "t_annx2" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5ND&open=AZ6aBbChrfn0lGGeP5ND&pullRequest=299

Check warning on line 175 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static prevMemDay" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5L9&open=AZ6aBbChrfn0lGGeP5L9&pullRequest=299

Check warning on line 73 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static partA" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Kj&open=AZ6aBbChrfn0lGGeP5Kj&pullRequest=299

Check warning on line 212 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static n_annec_matchdsm2" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Mi&open=AZ6aBbChrfn0lGGeP5Mi&pullRequest=299

Check warning on line 123 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make cbcCheckIntErr a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5IP&open=AZ6aBbChrfn0lGGeP5IP&pullRequest=299

Check warning on line 93 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static sendAliasToDvar" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Ky&open=AZ6aBbChrfn0lGGeP5Ky&pullRequest=299

Check warning on line 142 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make resimYear a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Ig&open=AZ6aBbChrfn0lGGeP5Ig&pullRequest=299

Check warning on line 150 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "PASS" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Mz&open=AZ6aBbChrfn0lGGeP5Mz&pullRequest=299

Check warning on line 150 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static PASS" field final 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Lo&open=AZ6aBbChrfn0lGGeP5Lo&pullRequest=299

Check warning on line 177 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make prevOutputMonth a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5I-&open=AZ6aBbChrfn0lGGeP5I-&pullRequest=299

Check warning on line 181 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make prevOutputDate a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5JC&open=AZ6aBbChrfn0lGGeP5JC&pullRequest=299

Check warning on line 95 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make showRunTimeMessage a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5Hz&open=AZ6aBbChrfn0lGGeP5Hz&pullRequest=299

Check warning on line 188 in wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControlData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make t_ts a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=CentralValleyModeling_wrims-engine&issues=AZ6aBbChrfn0lGGeP5JJ&open=AZ6aBbChrfn0lGGeP5JJ&pullRequest=299
View more details on SonarQubeCloud