Skip to content

fix(ci): run the DCO check only on pull requests from forks #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonvanlierde merged 1 commit into from
Oct 24, 2026
Merged

fix(ci): run the DCO check only on pull requests from forks #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/dco.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
name: dco

# Every commit in a pull request from an outside contributor must carry a Signed-off-by
# line: the Developer Certificate of Origin, as CONTRIBUTING.md asks. Maintainers' and
# bots' pull requests skip the job, which counts as passing.
# Every commit in a pull request from a fork must carry a Signed-off-by line: the
# Developer Certificate of Origin, as CONTRIBUTING.md asks. A pull request from a
# branch in this repository skips the job, which counts as passing: pushing that
# branch already needed write access.
on:
pull_request:

Expand All @@ -16,9 +17,7 @@ concurrency:
jobs:
sign-off:
name: DCO sign-off
if: >-
!contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.pull_request.author_association)
&& github.event.pull_request.user.type != 'Bot'
if: github.event.pull_request.head.repo.full_name != github.repository
runs-on: ubuntu-latest
timeout-minutes: 5
permissions:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ Before submitting:

## Sign Off Your Commits

Every commit in a pull request carries a `Signed-off-by:` line. It says you wrote the change or have the right to submit it under the project's licenses (AGPL-3.0-or-later for the plugin, Apache-2.0 for `r9cam_models` and the API specification): the [Developer Certificate of Origin 1.1](https://developercertificate.org/). `git commit -s` adds it; `git rebase --signoff upstream/main` (the branch you started from) adds it to commits you already made. The `dco` workflow fails a pull request from an outside contributor with a commit that lacks it. Organisation members' and the dependency bots' pull requests skip it.
Every commit in a pull request carries a `Signed-off-by:` line. It says you wrote the change or have the right to submit it under the project's licenses (AGPL-3.0-or-later for the plugin, Apache-2.0 for `r9cam_models` and the API specification): the [Developer Certificate of Origin 1.1](https://developercertificate.org/). `git commit -s` adds it; `git rebase --signoff upstream/main` (the branch you started from) adds it to commits you already made. The `dco` workflow fails a pull request from a fork with a commit that lacks it. Pull requests from a branch in this repository skip it.

## Release Process

Expand Down
Loading