Repository navigation
fix(ci): run the DCO check only on pull requests from forks - #66
Merged
Merged
Conversation
The skip keyed on the author's role in the pull request event, and the check still ran on a maintainer's own pull request in an organization repo where their membership is private. Pushing a branch to the repository needs write access, so checking forks covers every outside contribution without trusting that role.
Merging this PR will not alter performance1 warning
Comparing 
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dcocheck is meant to skip maintainers, but it ran on my own pull request here (#64) and failed. The skip read the author's role from the pull request event, and since my membership in CMLPlatform is private, that role didn't come through as a member.head.repo.full_name != github.repository). Pushing a branch to this repo already needs write access, so every outside contribution still gets checked, and branches from maintainers and the dependency bots skip it.Tests: this pull request comes from a branch here, so its own DCO job should show as skipped. The fork case runs on the next outside pull request.