Convert is_uniformly_false() method calls to attribute access#71
Merged
Conversation
Co-authored-by: shanest <351655+shanest@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on attribute invocation in cleaning PR
Convert is_uniformly_false() method calls to attribute access
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes remaining call sites still invoking Meaning.is_uniformly_false as a method after it was converted to a @cached_property, preventing TypeError: 'bool' object is not callable.
Changes:
- Updated
is_uniformly_false()invocations tois_uniformly_falsein 4 locations. - Ensured scripts/utilities correctly treat
is_uniformly_falseas a boolean attribute.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/examples/learn_quant/scripts/generate_expressions.py | Switches is_uniformly_false() to property access during expression filtering. |
| src/examples/modals/scripts/generate_expressions.py | Switches is_uniformly_false() to property access during expression filtering. |
| src/examples/modals/util.py | Switches is_uniformly_false() to property access when skipping unusable meanings. |
| src/examples/indefinites/scripts/generate_expressions.py | Switches is_uniformly_false() to property access during expression filtering. |
Comments suppressed due to low confidence (2)
src/examples/learn_quant/scripts/generate_expressions.py:214
- Variable creation_elapsed is not used.
creation_elapsed = time() - creation_start
src/examples/learn_quant/scripts/generate_expressions.py:5
- Module 'pathlib' is imported with both 'import' and 'import from'.
import pathlib
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #70 added
@cached_propertytois_uniformly_false, changing it from a method to a property. However, 4 call sites still used method invocation syntax, causingTypeError: 'bool' object is not callable.Changes
()from allis_uniformly_false()invocations to access as property:src/examples/learn_quant/scripts/generate_expressions.pysrc/examples/modals/scripts/generate_expressions.pysrc/examples/modals/util.pysrc/examples/indefinites/scripts/generate_expressions.py💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.