very minor semantics and pyproject cleaning#70
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes small semantics cleanups and build configuration tidying, plus a behavioral change to Meaning.is_uniformly_false. The code comments/docstrings are clarified, and the pyproject.toml build-system section is simplified.
Changes:
- Fix typos and punctuation in
Universe.__init__and theMeaningclass docstring; clarify the comment describing the defaultdistbehavior inMeaning.__init__. - Change
Meaning.is_uniformly_falseto use@cached_propertywhile preserving its existing implementation. - Clean up
pyproject.tomlby removing obsolete commented-outsetuptools/uvbuild configuration and standardizing onuv_build.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ultk/language/semantics.py |
Cleans up comments/docstrings, adjusts the description of the default dist, and converts is_uniformly_false into a @cached_property (currently breaking existing call sites that use it as a method). |
pyproject.toml |
Removes unused, commented-out legacy build-system configuration and keeps a concise uv_build-based build setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dist or tuple(1 / num_true_like if value else 0 for value in self.mapping), | ||
| ) | ||
|
|
||
| @cached_property |
There was a problem hiding this comment.
Adding @cached_property to is_uniformly_false changes its interface from a method to an attribute, but existing call sites (e.g. src/examples/.../generate_expressions.py and src/examples/modals/util.py) still invoke it as meaning.is_uniformly_false(), which will now raise a TypeError (bool object is not callable). Either remove the @cached_property decorator or update all call sites to access is_uniformly_false as an attribute (and, if desired, use @property instead of @cached_property).
| @cached_property |
There was a problem hiding this comment.
@copilot can you instead change the existing call sites to invoke it as an attribute instead?
Co-authored-by: shanest <351655+shanest@users.noreply.github.com>
Convert is_uniformly_false() method calls to attribute access
Forgot to close branch and accidentally made these small changes there