Skip to content

very minor semantics and pyproject cleaning#70

Merged
shanest merged 5 commits into
mainfrom
remove-frozendict
Jan 26, 2026
Merged

very minor semantics and pyproject cleaning#70
shanest merged 5 commits into
mainfrom
remove-frozendict

Conversation

@shanest
Copy link
Copy Markdown
Collaborator

@shanest shanest commented Jan 26, 2026

Forgot to close branch and accidentally made these small changes there

Copilot AI review requested due to automatic review settings January 26, 2026 18:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes small semantics cleanups and build configuration tidying, plus a behavioral change to Meaning.is_uniformly_false. The code comments/docstrings are clarified, and the pyproject.toml build-system section is simplified.

Changes:

  • Fix typos and punctuation in Universe.__init__ and the Meaning class docstring; clarify the comment describing the default dist behavior in Meaning.__init__.
  • Change Meaning.is_uniformly_false to use @cached_property while preserving its existing implementation.
  • Clean up pyproject.toml by removing obsolete commented-out setuptools/uv build configuration and standardizing on uv_build.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

File Description
src/ultk/language/semantics.py Cleans up comments/docstrings, adjusts the description of the default dist, and converts is_uniformly_false into a @cached_property (currently breaking existing call sites that use it as a method).
pyproject.toml Removes unused, commented-out legacy build-system configuration and keeps a concise uv_build-based build setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dist or tuple(1 / num_true_like if value else 0 for value in self.mapping),
)

@cached_property
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @cached_property to is_uniformly_false changes its interface from a method to an attribute, but existing call sites (e.g. src/examples/.../generate_expressions.py and src/examples/modals/util.py) still invoke it as meaning.is_uniformly_false(), which will now raise a TypeError (bool object is not callable). Either remove the @cached_property decorator or update all call sites to access is_uniformly_false as an attribute (and, if desired, use @property instead of @cached_property).

Suggested change
@cached_property

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you instead change the existing call sites to invoke it as an attribute instead?

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 26, 2026

@shanest I've opened a new pull request, #71, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits January 26, 2026 18:46
Co-authored-by: shanest <351655+shanest@users.noreply.github.com>
Convert is_uniformly_false() method calls to attribute access
@shanest shanest merged commit 35b5990 into main Jan 26, 2026
1 of 2 checks passed
@shanest shanest deleted the remove-frozendict branch January 26, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants