HDN lightning example - #40
Conversation
jdeschamps
left a comment
jdeschamps
left a comment
There was a problem hiding this comment.
There are two small changes to the text that are requested, and one big question about the N2V notebook disappearing.
I also made notes for API changes but they are not related to this PR.
There was a problem hiding this comment.
Why did you delete the Noise2Void example? Beyond being unnecessary, that will also make the website crash.
| "The BSD68 dataset was adapted from K. Zhang et al (TIP, 2017) and is composed of natural\n", | ||
| "images. The noise was artificially added, allowing for quantitative comparisons with the\n", | ||
| "ground truth, one of the benchmark used in many denoising publications. Here, we check \n", | ||
| "the performances of Noise2Void using the Lightning API of CAREamics.\n", |
There was a problem hiding this comment.
| "the performances of Noise2Void using the Lightning API of CAREamics.\n", | |
| "the performances of HDN using the Lightning API of CAREamics.\n", |
| " experiment_name=\"bsd68_hdn\",\n", | ||
| " data_type=\"tiff\",\n", | ||
| " axes=\"SYX\",\n", | ||
| " z_dims=[32] * 4,\n", |
There was a problem hiding this comment.
I am making a comment here for reference, but it does not belong to this PR.
Note: It is horrible for users to have to do something like [32] * 4. What does it mean? Why 4? etc. The convenience function should make it easy. For instance with a parameter (I suppose that's what it is about) n_levels or n_depth (should be similar to what is in the config, provided it has an informative name).
| " patch_size=(128, 128),\n", | ||
| " batch_size=64,\n", | ||
| " num_epochs=5,\n", | ||
| " predict_logvar=\"pixelwise\",\n", |
There was a problem hiding this comment.
Note: If I recall, this could be a bool.
| "Note that here we modify the prediction loop, but this will be changed in the near\n", | ||
| "future." |
There was a problem hiding this comment.
| "Note that here we modify the prediction loop, but this will be changed in the near\n", | |
| "future." |
| " data_type=\"tiff\",\n", | ||
| " axes=\"YX\",\n", | ||
| " batch_size=1,\n", | ||
| " tta_transforms=False, #not implemented\n", |
There was a problem hiding this comment.
Note: kick out tta parameters fully until we implement it.
|
Closes #38 |
2 participants
Adds the lightning API notebook for HDN.
Uses newly proposed configuration pipeline see careamics #511.
Performance haven't been tested.