MicroSplit notebook for lightning API - #39
Open
CatEek wants to merge 7 commits into
Open
Conversation
CatEek
requested review from
federico-carrara,
jdeschamps,
melisande-c and
veegalinova
September 16, 2025 13:27
jdeschamps
approved these changes
Sep 17, 2025
Member
There was a problem hiding this comment.
It seems your PR are sharing commits, where they shouldn't!
| "# save the image\n", | ||
| "im = Image.fromarray(cover * 255)\n", | ||
| "im = im.convert(\"L\")\n", | ||
| "im.save(\"BSD68_Noise2Void_lightning_api.jpeg\")" |
Member
There was a problem hiding this comment.
Suggested change
| "im.save(\"BSD68_Noise2Void_lightning_api.jpeg\")" | |
| "im.save(\"HT_LIF_MicroSplit_lightning_api.jpeg\")" |
jdeschamps
requested changes
Sep 17, 2025
jdeschamps
left a comment
jdeschamps
left a comment
Member
There was a problem hiding this comment.
This branch needs to be rebased once the HDN example has the comments included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a notebook draft.
Uses newly proposed configuration pipeline(see careamics #514)
Performance haven't been tested, most likely there're bugs in the config.
Should be viewed after #40