Skip to content

7142: test protected Ping response after DebugLink read #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BitHighlander wants to merge 1 commit into
base: audit/7142-ripple-display-response
Choose a base branch
from
Draft

7142: test protected Ping response after DebugLink read #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/test_msg_ping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,25 @@

class TestPing(common.KeepKeyTest):

def test_protected_ping_preserves_message_presence_after_debug_read(self):
self.requires_firmware("7.14.2")
for message in (None, '', 'ping response'):
with self.subTest(message=message):
request = proto.Ping(button_protection=True)
if message is not None:
request.message = message
response = self.client.call_raw(request)
self.assertIsInstance(response, proto.ButtonRequest)
# Read the screen while the normal response is suspended.
self.client.debug.read_layout()
self.client.debug.press_yes()
response = self.client.call_raw(proto.ButtonAck())
self.assertIsInstance(response, proto.Success)
self.assertEqual(response.HasField('message'), message is not None)
if message is not None:
self.assertEqual(response.message, message)


def test_ping(self):
self.setup_mnemonic_pin_passphrase()
self.client.clear_session()
Expand Down