Skip to content

test(ripple): require unsupported memo rejection on 7.14.3 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BitHighlander wants to merge 1 commit into
base: audit/7143-ripple-display-response
Choose a base branch
from
+17 −0
Draft

test(ripple): require unsupported memo rejection on 7.14.3 #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tests/test_msg_ripple_sign_tx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,23 @@ def test_sign_with_thorchain_memo(self):
"plain send must not contain Memos array (0xF9 0xEA marker sequence)"
)

def test_unsupported_memo_is_rejected(self):
self.requires_fullFeature()
self.requires_firmware("7.14.3")
if self.firmware_at_least("7.15.0"):
self.skipTest("Ripple memos are implemented in 7.15")
self.setup_mnemonic_allallall()
msg = messages.RippleSignTx(
address_n=parse_path("m/44'/144'/0'/0/0"),
payment=messages.RipplePayment(
amount=100000000,
destination="rBKz5MC2iXdoS3XgnNSYmF69K1Yo4NS3Ws"),
flags=0x80000000, fee=100000, sequence=25,
memo="routing-memo")
with self.assertRaises(CallException) as caught:
self.client.call(msg)
self.assertEqual(caught.exception.args[0], types.Failure_SyntaxError)

def test_ripple_sign_invalid_fee(self):
self.requires_fullFeature()
self.requires_firmware("6.4.0")
Expand Down