test(ripple): require unsupported memo rejection on 7.14.3 - #80
Draft
BitHighlander wants to merge 1 commit into
Draft
test(ripple): require unsupported memo rejection on 7.14.3#80BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a permanent regression requiring full 7.14.3 to reject a nonempty Ripple memo with Failure_SyntaxError, rather than signing a transaction that omits it. Gate out Bitcoin-only, earlier firmware and 7.15 where memo support is implemented.
The new rejection test and existing signing/invalid-fee tests all pass against the fixed full emulator at 06d84f561. Before the firmware fix, the same supplied memo produced a successful transaction without its memo. Forced UDP and isolated storage; no hardware.
Firmware pin integration remains pending. Fork audit unit; no upstream merge or Copilot request.