Skip to content

test: require Zcash export consent and reject account aliases #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BitHighlander wants to merge 1 commit into
base: audit/715-zcash-applicability
Choose a base branch
from
Draft

test: require Zcash export consent and reject account aliases #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions tests/test_msg_zcash_orchard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
import unittest
import common
import binascii
import pytest
from keepkeylib.client import CallException
from keepkeylib import types_pb2 as proto_types

# Pallas curve constants
PALLAS_P = 0x40000000000000000000000000000000224698fc094cf91b992d30ed00000001
Expand Down Expand Up @@ -42,6 +45,30 @@ def setUp(self):
self.requires_firmware("7.14.0")
self.requires_message("ZcashGetOrchardFVK")

def test_fvk_export_requires_consent_even_when_display_is_false(self):
self.requires_firmware("7.15.0")
self.setup_mnemonic_allallall()
self.client.setup_debuglink(False, True)
try:
with pytest.raises(CallException) as caught:
self.client.zcash_get_orchard_fvk(
address_n=[], account=0, show_display=False)
self.assertEqual(caught.value.args[0],
proto_types.Failure_ActionCancelled)
finally:
self.client.setup_debuglink(True, True)

def test_explicit_account_cannot_alias_across_hardened_bit(self):
self.requires_firmware("7.15.0")
self.setup_mnemonic_allallall()
for account in (0x80000000, 0xffffffff):
with self.subTest(account=account):
with pytest.raises(CallException) as caught:
self.client.zcash_get_orchard_fvk(
address_n=[], account=account, show_display=False)
self.assertEqual(caught.value.args[0],
proto_types.Failure_SyntaxError)

def test_fvk_field_ranges(self):
"""FVK components must be in valid field ranges.

Expand Down