test: require Zcash export consent and reject account aliases - #74
Draft
BitHighlander wants to merge 1 commit into
Draft
test: require Zcash export consent and reject account aliases#74BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require viewing-key export to honor physical rejection even when the host sets show_display=false. Reject explicit account indices with the hardened bit set instead of deriving an aliased account.
Both regressions fail against the preceding canonical candidate. With the firmware fix, all 19 Orchard, seed-fingerprint, and device PCZT tests pass, including both account-boundary subtests. Existing valid account and reference-key vectors remain covered.