Repository navigation
Reliable interaction between the ARM API Reviewer and Critic - #43782
Closed
Ravi Eda (ravimeda) wants to merge 9 commits into
Closed
Ravi Eda (ravimeda) wants to merge 9 commits into
Ravi Eda (ravimeda) wants to merge 9 commits into
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
Ravi Eda (ravimeda)
force-pushed
the
raeda/reviewer-critic
branch
from
June 5, 2026 14:20
4114a3e to
51a4f4e
Compare
Ravi Eda (ravimeda)
force-pushed
the
raeda/reviewer-critic
branch
from
June 8, 2026 12:33
a549ad6 to
a1b67e1
Compare
Ravi Eda (ravimeda)
marked this pull request as ready for review
June 8, 2026 12:36
Ravi Eda (ravimeda)
requested review from
a team,
Arthur Ma (ArthurMa1978),
Crystal YU (chunyu3),
Haoling Dong (haolingdong-msft),
laxmankumar12,
Renhe Li (lirenhe) and
Suhas Rao (ARM) (raosuhas)
as code owners
June 8, 2026 12:36
Member
Author
|
Thanks for the contribution, Sandip Shahane (@sandipsh) |
Praveen Kuttappan (praveenkuttappan)
approved these changes
Jun 11, 2026
Member
Author
|
Suhas Rao (ARM) (@raosuhas) please could you take a look |
Ravi Eda (ravimeda)
enabled auto-merge (squash)
June 16, 2026 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves reliability of the Reviewer <--> Critic loop for ARM API reviews by
tightening protocol contracts and fallback behavior. The Critic was introduced in
#43494
What Changed
completed with no output" returns are treated as host-side failures, retried up
to 3 times with a reduced/compact-mode payload, then auto-fall back to
critic-mode=unavailable.carry-over verdicts), with session-SHA re-fetch pinning and file-drift
(
carry-over-stale) checks.and sensible defaults; simplified the graph-handling flag to
Graphs: true|falseand folded prior-iteration carryover inline into the report.
unavailable-mode disclosure after bounded retries (no user action required).
reconciliation FAILs are now overridable with justification.
reviewer/critic workflow).
critic-subagent-failure-auto-unavailableprotocol-safety test, refreshed fast-path / suppressions-yaml / typespec-required
evals, and a hardened
run-evals.ps1with infrastructure-only auto-retry.Impact
brittle manual-paste handoff step.
eval suite.
Scope
Agent protocol, documentation, and evaluation-suite (test tooling) updates only.
No REST API spec surface changes. No SDK generation changes.