Repository navigation
Harden ARM API Reviewer ↔ Critic interaction protocol (issue #44098) - #44099
Ravi Eda (ravimeda) merged 6 commits into
Conversation
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛Comment generated by summarize-checks workflow run. |
Co-authored-by: ravimeda <12752450+ravimeda@users.noreply.github.com>
… catalog description Co-authored-by: ravimeda <12752450+ravimeda@users.noreply.github.com>
|
Copilot analyze failing checks . Apply fixes. |
The only failing checks are Protected Files (two instances), which flag these 4 files:
The There is no code fix that can resolve this — the check is working as designed. The workflow itself is also a protected file, so it cannot be modified to add an exclusion either. The check explicitly states: "If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections." Since the agent file updates are intentional, this PR needs to be merged by an Azure SDK team member using branch protection bypass. |
Copilot format the changes using prettier as identified in the failing check - https://github.com/Azure/azure-rest-api-specs/actions/runs/27828686838/job/82707418772?pr=44099 |
Co-authored-by: ravimeda <12752450+ravimeda@users.noreply.github.com>
Applied prettier formatting to the 6 flagged files in commit The remaining Protected Files failures for |
|
Copilot update the branch |
…wer-harden-critic-interaction Co-authored-by: ravimeda <12752450+ravimeda@users.noreply.github.com>
Branch updated — merged latest |
|
Copilot we need a new commit so that the checks can run. Update the branch so that a new commit is pushed. |
…wer-harden-critic-interaction Co-authored-by: ravimeda <12752450+ravimeda@users.noreply.github.com>
Merged latest |
Implements the 7 reliability hardening items from issue #44098 (scope originally explored in closed PR #43782). Changes are confined to agent instruction files, protocol docs, skill references, and the eval suite — no
specification/**, SDK, oreng/files touched.What changed
Protocol & dispatch (
arm-api-review-critic.protocol.md,arm-api-review-critic-inputs.template.md)critic-mode=unavailablewith no user action requiredcritic-mode=session-handoffis no longer a valid value; fallback ladder reduced from 3 rungs to 2 (subagent → auto-unavailable)downstream-ci-conflict,suppression-path-mismatch,reconciliation, and 4 others become overridable with validated justificationgraphs-produced: true|false|downgraded|degraded→Graphs: true|false(old 4-value schema still accepted for backward compat)Agent files (
arm-api-reviewer.agent.md,arm-api-review-critic.agent.md)downstream-ci-conflictandsuppression-path-mismatchmarked overridable;Graphs: true|falseacceptedSupporting docs
downstream-ci-impact.md:downstream-ci-conflict/suppression-path-mismatchfailures documented as overridable with justificationthink-in-graphs.md: allgraphs-produced:variants replaced withGraphs: false+ backward compat notesEval suite
eval-protocol-safety.yaml: stimulus 160001 updated (session-handoff → auto-unavailable); new stimulus 160011 (critic-subagent-failure-empty-response-not-pass) addedREADME.md: 16xxxx count 10 → 11, total 51 → 52Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
tspconfig.yamltemplates:Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.