Skip to content

Production Deploy: Pin deploy user to circleci #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidsmejia merged 2 commits into from
Jul 3, 2026
Merged

Production Deploy: Pin deploy user to circleci #3606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c629eac
ci: pin DEPLOY_USER to circleci; add DEPLOY_NOTIFIER for Slack
davidsmejia Jul 3, 2026
288d43c
Merge pull request #3605 from AlexsLemonade/davidsmejia/rbio-deploy-user
davidsmejia Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/slackpost_deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if [[ $username == "" ]]; then
fi

# ------------
text="New deployment! Woo! $DEPLOY_USER: $BRANCH $DEPLOY_TAG"
text="New deployment! Woo! $DEPLOY_NOTIFIER: $BRANCH $DEPLOY_TAG"

escapedText=$(echo "$text" | sed 's/"/\"/g' | sed "s/'/\'/g")

Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,13 @@ jobs:
deploy:
name: Deploy
env:
DEPLOY_USER: ${{ github.actor }}
# DEPLOY_USER is the Terraform stack identity: it names every resource and
# selects the remote state file (see TF_VAR_user). Keep it "circleci" to
# match the existing stacks — it was hardcoded under CircleCI, and if it
# became the pushing user (github.actor) every deploy would fork a new stack.
DEPLOY_USER: circleci
# Who actually triggered the deploy; shown in the Slack notification.
DEPLOY_NOTIFIER: ${{ github.actor }}
if: startsWith(github.ref, 'refs/tags/v') && ! endsWith(github.ref, '-hotfix')
needs:
- determine_branch
Expand Down Expand Up @@ -743,7 +749,13 @@ jobs:
deploy_hotfix:
name: Deploy Hotfix
env:
DEPLOY_USER: ${{ github.actor }}
# DEPLOY_USER is the Terraform stack identity: it names every resource and
# selects the remote state file (see TF_VAR_user). Keep it "circleci" to
# match the existing stacks — it was hardcoded under CircleCI, and if it
# became the pushing user (github.actor) every deploy would fork a new stack.
DEPLOY_USER: circleci
# Who actually triggered the deploy; shown in the Slack notification.
DEPLOY_NOTIFIER: ${{ github.actor }}
if: startsWith(github.ref, 'refs/tags/v') && endsWith(github.ref, '-hotfix')
needs:
- determine_branch
Expand Down
Loading