Production Deploy: Pin deploy user to circleci#3606
Merged
Merged
Conversation
ci: pin DEPLOY_USER to circleci; add DEPLOY_NOTIFIER for Slack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the deployment workflow to distinguish between the identity used for Terraform resources and the user who actually triggered the deployment. The changes ensure that the Terraform stack identity remains consistent across deployments, while the Slack notification correctly attributes the deploy to the triggering user.
Deployment environment variable changes:
DEPLOY_USERenvironment variable is now hardcoded ascircleciin both thedeployanddeploy_hotfixjobs to maintain consistent Terraform stack naming and state management. [1] [2]DEPLOY_NOTIFIER, is introduced to capture the actual user who triggered the deployment (github.actor). This value is now used in Slack notifications. [1] [2]Slack notification update:
.github/scripts/slackpost_deploy.shnow usesDEPLOY_NOTIFIERinstead ofDEPLOY_USERto correctly display the deploy triggerer.