Repository navigation
Update README and templates - #1778
Conversation
IaroslavKhvorostenko
left a comment
There was a problem hiding this comment.
Thanks for the cleanup — the README fixes (broken <a></a>, Website URL, X/Twitter, reporting-tool link) and the template updates look good, and I checked the filter changes against the current app catalog.
A few optional nits (your call):
DNS Protocol: the description says "Skip this if DNS protection is disabled", but the field is nowrequired: true. Maybe reword to "If you don't use DNS protection, select 'DNS protection disabled'".- Placeholders use
macOS Golden Gate 27.2/Safari 27.2— 27.2 is a beta; the public release is 27.0. Consider using a released version as the example. - README screenshots are still from v2.12 while the app is on 2.19/2.20 — might be worth refreshing while you're here.
alt="Beta version>"has a stray>.- Not a blocker: for this repo
app=macwould give better attribution (utm_source=mac) thanapp=home, but matchingconfig.ymlis fine.
For the record, I verified the rest against the app: removing Block Java is correct (the setting was removed in v2.20, #1705), and the filter-list changes match the current catalog — Mail Tracking Protection (25), Web Annoyances Ultralist (201) and Dandelion Sprout's Anti-Malware List (259) are present, and NoCoin is gone.
Thanks again!
|
Thanks for your help with this @IaroslavKhvorostenko!
I'll need some additional help with the following:
Screenshots are currently sourced from
I did use the exact URL sourced to match all repos, but I'm happy to resolve this across the board. I just don't know what I'd put for all the other products, and where I can get this list from. Otherwise, this would be the only repo with a different URL. |
There was a problem hiding this comment.
Thanks for the quick turnaround — I re-checked the updated files against the current app catalog, including the localized filter names the app actually displays, and everything checks out:
Steveo's→Stevo's— fixed ✓- DNS wording (
DNS Serverdescription +DNS Protocol) — fixed ✓ macOS Golden Gate 27.0.1/Safari 27.0.1— good, thanksalt="Beta version"— fixed ✓- The language-specific list is now fully aligned with the catalog (56 items) — nice
On your questions:
- Screenshots: no need for CDN access — leaving the v2.12 images as-is is fine for this PR; a maintainer can refresh them separately once new assets are available.
Thanks again!
Changes
README.md
<a hrefshowing space and underline after SVG imagehttps://link.adtidy.org/forward.html?action=report&app=home&from=github)01-bug-report.yaml
config.yml(https://link.adtidy.org/forward.html?action=report&app=home&from=github)02-feature-request.yaml
03-question.yaml
config.yml
Context
I've noticed that the
README.mdfiles are not unified in layout, need updated links and to resolve a few visual issues. The GitHub templates for Issues were also with outdated filter lists and with minor opportunities for some tweaks to bring it up to date with recent releases and fix a few things here and there.Since working with others on the other PRs for updating the
README.mdand template files, there are a few more things that should be applied to the templates for the sake of cohesion. These changes have already been applied to this existing PR, but PRs for this second revision have been made if already merged before these changes:Also added further repos that could use the same update treatment: