Potential fix for code scanning alert no. 19: Uncontrolled data used in path expression#28
Draft
zsxh1990 wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 19: Uncontrolled data used in path expression#28zsxh1990 wants to merge 1 commit into
zsxh1990 wants to merge 1 commit into
Conversation
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| file_path = FRONTEND_DIST / full_path | ||
| if full_path and file_path.exists() and file_path.is_file(): | ||
| dist_root = FRONTEND_DIST.resolve() | ||
| file_path = (dist_root / full_path).resolve() |
| except ValueError: | ||
| is_within_dist = False | ||
|
|
||
| if is_within_dist and file_path.exists() and file_path.is_file(): |
| except ValueError: | ||
| is_within_dist = False | ||
|
|
||
| if is_within_dist and file_path.exists() and file_path.is_file(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/whitehat-bot/automatic-potato/security/code-scanning/19
To fix this safely, resolve the requested path against a trusted base directory and verify the resolved target remains inside that base before serving it.
Best fix in this file:
new_ui/backend/main.py, insideserve_spa(lines ~167–175), replace the currentfile_pathconstruction/check with:FRONTEND_DISTto an absolute canonical base.(base / full_path).resolve().relative_toin atry/except ValueError).FileResponsewhen the candidate is inside base and is an existing file.index.htmlas before.No new dependency is needed.
Path.resolve()/relative_to()are from existingpathlib.Pathimport.Suggested fixes powered by Copilot Autofix. Review carefully before merging.