Add chip when submitted from keyboard - #12
Open
North101 wants to merge 2 commits into
Open
Conversation
Owner
|
Thank you for your contribution. I like the idea to submit the most similar suggestion on submit when non is selected. I think, however, this should not be the default. Could you make this configurable? |
Contributor
Author
|
I've added the bool field |
North101
force-pushed
the
add_chip_onsubmit
branch
from
June 3, 2021 18:18
774ff88 to
272f2bf
Compare
North101
force-pushed
the
add_chip_onsubmit
branch
from
June 4, 2021 13:27
272f2bf to
cb2612a
Compare
Contributor
|
There is no need to create a separate function for this, function passed to fieldViewBuilder parameter has an argument called onFieldSubmitted which does exactly the same as yours function onSubmitted. The only change could be to make this configurable so it could looks like this: onSubmitted: widget.addSuggestedOnSubmit ? (_) => onFieldSubmitted() : null, |
|
Is there some update on this feature? Will it be merged at some point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new chip when submitted from the keyboard by taking the 1st suggested value (if any exist).