Skip to content

Note in MAINTAINING.md why the Django dependency carries no upper bound - #864

Merged
dyve merged 1 commit into
mainfrom
remove-django-upper-bound
Aug 28, 2026
Merged

dyve merged 1 commit into
mainfrom
remove-django-upper-bound

Conversation

@dyve

@dyve dyve commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

This repo has never had an upper bound on its Django dependency, so nothing changes here functionally. This documents why, so the rule does not drift back — django-marina and django-bootstrap4 had both grown a <7.0 cap, which is being removed.

A cap cannot make an install fail on a new Django major. The resolver is free to backtrack to an older release of the package whose metadata never had one. Verified against live PyPI metadata:

$ uv pip compile  ("django-bootstrap4", "django<5.2")
django==5.1.15
django-bootstrap4==26.1     ← not an error. an old release.

So a cap does not buy a clean failure — it buys a silent downgrade to old, untested code. Capping the current release cannot close a door that already-published metadata left open.

The django-version: main job in the CI matrix is the actual early warning: it breaks while the next major is still in development, when there is still time to release.

Test plan

  • just lint passes
  • Note verified byte-identical to django-marina's canonical version
  • Docs only — the Django>=5.2 requirement is unchanged here

Propagated verbatim from django-marina. This repo already had no cap;
django-marina and django-bootstrap4 had grown one and are dropping it.

A cap cannot make an install fail on a new Django major -- the resolver
backtracks to an older release whose metadata never had one, so users
silently get old code instead of an error.
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33160485033

Coverage remained the same at 96.076%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 686
Covered Lines: 664
Line Coverage: 96.79%
Relevant Branches: 206
Covered Branches: 193
Branch Coverage: 93.69%
Branches in Coverage %: Yes
Coverage Strength: 13.55 hits per line

💛 - Coveralls

@dyve
dyve merged commit 0b39ab2 into main Aug 28, 2026
20 checks passed
@dyve
dyve deleted the remove-django-upper-bound branch August 28, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants