Support terminal scrolling - #2
Open
geoffjay wants to merge 1 commit into
Open
Conversation
zortax
requested changes
Feb 6, 2026
Owner
There was a problem hiding this comment.
Hey thanks for the contribution!
Two things I noticed with this:
- scrolling direction seems to be wrong way around on my system
- in e.g. nvim, scrolling seems much faster than in other terminal emulators
Additionally, I think it would be nice to render a small indicator/scrollbar when scrolled up (configurable) and also, the view should jump back down on input.
Feel free to address those things, otherwise I'll work on this next week :)
Comment on lines
+795
to
+801
| // Calculate number of lines to scroll | ||
| // Note: We negate the delta because: | ||
| // - On macOS with natural scrolling, swipe up gives negative y delta | ||
| // - But swipe up should show OLDER content (positive scroll offset) | ||
| // - For scroll_display, positive delta scrolls toward history (older content) | ||
| let pixel_delta = event.delta.pixel_delta(px(20.0)).y; | ||
| let lines = -pixels_to_scroll_lines(pixel_delta, self.renderer.cell_height); |
Owner
There was a problem hiding this comment.
Not sure about expected behavior on macOS, but on my linux machine this scrolls the wrong way around (I have to scroll "down" to go up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested this by doing:
cargo runopencodewhich uses an alternative method of scrolling