TEMP: isolate which fix is actually necessary (do not merge) - #317
TEMP: isolate which fix is actually necessary (do not merge)#317benceharomi wants to merge 3 commits into
Conversation
Picks up the fix for real proof generation (relayer-utils version regression) and the Noir/SP1/local-proving restrictions, keeping registry on the same SDK version actually proven to work end-to-end.
nightly.29 crashed registry's SSR with 'X.getCiphers is not a function' - a crypto-browserify bundling regression triggered by the relayer-utils downgrade in nightly.29, root-caused and fixed in zkemail/zk-email-sdk-js#99 (node:crypto wasn't aliased alongside crypto). Verified locally with the real published package: build and start succeed, no crash on previously-failing routes.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Render
Destroyed
|
Isolation test complete: confirmed addInitScript alone (no page.tsx change) fixes the CI failure. Applied as a clean, minimal commit directly on #316. |
2 participants
Temporary PR to test in real CI whether the SDK version bump alone reproduces the targetChainSelector failure, before layering fixes back one at a time. Will be closed once the isolation test is done.