Skip to content

Remove proxy pallet#53

Open
drgora wants to merge 4 commits intomainfrom
dr/remove_proxy
Open

Remove proxy pallet#53
drgora wants to merge 4 commits intomainfrom
dr/remove_proxy

Conversation

@drgora
Copy link
Contributor

@drgora drgora commented Mar 20, 2026

We do not have practical use cases at this time, so we simplify the runtime configuration

@drgora drgora requested review from 95DDB and la10736 March 20, 2026 10:56
Copy link
Contributor

@la10736 la10736 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Comment on lines 81 to 86
pub struct NormalFilter;
impl Contains<RuntimeCall> for NormalFilter {
fn contains(c: &RuntimeCall) -> bool {
match c {
// We filter anonymous proxy as they make "reserve" inconsistent
// See: https://github.com/paritytech/polkadot-sdk/blob/v1.9.0-rc2/substrate/frame/proxy/src/lib.rs#L260
RuntimeCall::Proxy(method) => !matches!(
method,
pallet_proxy::Call::create_pure { .. }
| pallet_proxy::Call::kill_pure { .. }
| pallet_proxy::Call::remove_proxies { .. }
),
_ => true,
}
fn contains(_c: &RuntimeCall) -> bool {
true
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substrate already provide something like this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, removed in favor of Everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants