[codex] Fix Codex stop hook index fallback#599
Draft
stevenkleinhens wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mktempcreates unique files instead of a literalXXXXXX.jsonpath.Root cause
The stop hook used a macOS-incompatible
mktemp ...XXXXXX.jsontemplate and then ran a fullmemsearch indexafter each stop-hook memory write. With repeated stop workers, that could overwrite worker payloads and spawn redundant full index processes even thoughmemsearch watchshould normally own incremental indexing.Validation
uv run pytest tests/test_codex_stop_hook_worker.py tests/test_codex_stop_hook_utf8.py -quv run ruff check tests/test_codex_stop_hook_worker.pybash -n plugins/codex/hooks/common.sh plugins/codex/hooks/stop.shgit diff --checkNote: a full
uv run pytest -qreached199 passed, 7 skippedbefore I interrupted a Milvus Lite reopen test that was retrying a refused local socket; that appears unrelated to this hook change.