Repository navigation
feat(auth): User Login - #470
Merged
Merged
Conversation
feat(auth): add login domain types
feat(auth): add login API client
feat(user-login): merge into Login Frontend
feat(auth): add login request mapper
feat(auth): add useLogin/useLogout hooks
# Conflicts: # client/src/app/routes/AppRoutes.tsx # client/src/locals/en/ui.json # client/src/locals/ja/ui.json
…er's id on MyPageContainer
…tainer test to id passthrough
…e-container feat: share UserProfileContainer between /mypage and /users/:id
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
login/logout/getCurrentUserto the auth API client (Bearer token auth, Sanctum-style{status,data}envelope)toLoginRequestmapper,useLogin/useLogouthooks, and sharedAuthProvider/useAuth/token storageLoginFormandLoginContainer, wired to/login; on success navigates to/mypageRequireAuth(redirects to/loginwhen unauthenticated) and wire it around/mypageonly —/heritagesand other public routes stay open to unregistered users/mypageshares the exact same profile view/edit/delete implementation as/users/:idvia a newUserProfileContainer(acceptsidas a prop):UserGetContainerpasses the route param's id,MyPageContainerpasses the authenticated user's own id fromuseAuth(). No URL redirect —/mypagestays/mypagelogin/loginError/logouti18n keys (en/ja)/mypageshowing that user's own profileTest plan
npx tsc --noEmitnpx jest(206 tests)npm run buildnpm run format:checknpm run lint