Repository navigation
feat: share UserProfileContainer between /mypage and /users/:id - #469
Merged
zigzagdev merged 5 commits intoJul 28, 2026
Merged
Conversation
…er's id on MyPageContainer
…tainer test to id passthrough
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserProfileContainer(acceptsid: numberas a prop): owns the get/update/delete hooks, immediate-reflection state, and rendersUserProfileView— this is the shared implementationUserGetContainer(/users/:id) becomes a thin wrapper: readsidfrom the route param, passes it throughMyPageContainer(/mypage) becomes a thin wrapper: readsidfromuseAuth().user.id(the authenticated user's own id), passes it through/mypagestays/mypage, it just renders the same component tree as viewing your own/users/:id/mypageplaceholder (tracked separately, not re-added here)user-profile-container.test.tsx;user-get-container.test.tsxand the newmypage-container.test.tsxonly verify each wrapper passes the right id throughRelated
Closes #468
Test plan
npx tsc --noEmitnpx jest(206 tests)npm run format:checknpm run build