Repository navigation
feat(user): User Information Delete Method - #464
Merged
Merged
Conversation
feat(user): add deleteUser API client
…ooks feat(user): add useDeleteUser hook
…ontainer feat(user): wire user delete into UserGetContainer and UserProfileView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteUser(id)to the user API client (DELETE /api/v1/users/:id,204 No Content— no response body,Promise<void>)id, there's no form-values object with a different shape to convert (see feat: 削除対象をAPIリクエストへ変換するmapperを追加 #424, closed as not needed)useDeleteUserhook: managesdone/isLoading/error, aborts the in-flight request on resubmit/unmount, matchinguseCreateUser/useUpdateUser/users/:idpage instead of a separate route:UserGetContainerdrivesuseDeleteUserand navigates to/heritagesonce deletion completesUserProfileViewgains a "Delete User" button that opens a confirmation dialog (MUIDialog); confirming calls the delete, cancelling is a no-op; shows an error panel on failureuserDeleteButton/userDeleteConfirmTitle/userDeleteConfirmMessage/userDeleteErrori18n keys (en/ja)Related
Closes #422
Test plan
npx tsc --noEmitnpx jest src/app/features/usernpx prettier --checkon the touched files