Use mise for container language versions, add no-test system prompt#312
Merged
Use mise for container language versions, add no-test system prompt#312
Conversation
ghost
approved these changes
Mar 5, 2026
There was a problem hiding this comment.
All changes look good. The PR successfully replaces apk-based language installs with mise, adds appropriate system prompts for containerized sessions, and includes comprehensive test coverage for the new functionality. No issues found.
Update (Mar 5, 2026 00:24 UTC, commit f05a881): Clean implementation of mise-based language version management and container system prompt. All changes are well-tested with comprehensive new test coverage. No issues found in the new code.
ghost
approved these changes
Mar 5, 2026
ghost
approved these changes
Mar 5, 2026
…ompt Replace apk-based Ruby/Python installs with mise in generated container Dockerfiles so the exact version from .ruby-version/.python-version is used. Mise is installed as the claude user via su-exec for proper permissions and legacy docker build compatibility. Add a container-specific system prompt telling Claude not to run tests (no DB/services/credentials available) and to rely on CI instead. Also removes the earlier bin/setup auto-send approach that tried to run host-side setup scripts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zhubert
force-pushed
the
container-mise-setup
branch
from
0c3f897 to
f05a881
Compare
ghost
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ruby-version/.python-versionis respectedbin/setupauto-send approach (host-side setup scripts don't belong in containers)Test plan
miseInstallBlock(Ruby+Python, no-mise languages, default version, empty)ruby --versionmatches.ruby-version🤖 Generated with Claude Code