#1684: add pagination to resolved_conversations GraphQL query#1822
Merged
Conversation
VasilevNStas
force-pushed
the
1684-resolved-pagination
branch
from
6e8c307 to
0202eea
Compare
Contributor
Author
|
@yegor256 plz review |
VasilevNStas
force-pushed
the
1684-resolved-pagination
branch
from
c7c7368 to
0202eea
Compare
Member
|
@VasilevNStas merge conflicts here |
VasilevNStas
force-pushed
the
1684-resolved-pagination
branch
from
0202eea to
ad3e21e
Compare
Contributor
Author
|
@VasilevNStas Thanks for the contribution! You've earned +24 points. Please, keep them coming. Your running score is +3152; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1684
Fbe.github_graph.resolved_conversationsusesreviewThreads(first: 100)without pagination, missing PRs with >100 resolved conversations.Fix: replace the non-paginated call with a direct
Fbe.github_graph.query(...)that loops through all pages using cursor-based pagination (hasNextPage/endCursor). The query fetches onlyisResolved+pageInfo, keeping it lightweight.Same error handling (
GraphQL::Client::Error,Octokit::NotFound/Deprecated/Forbidden) is preserved.