#1646: guard Integer(pull.dig(:user, :id)) against nil on deleted PR author#1817
Open
VasilevNStas wants to merge 1 commit into
Open
#1646: guard Integer(pull.dig(:user, :id)) against nil on deleted PR author#1817VasilevNStas wants to merge 1 commit into
VasilevNStas wants to merge 1 commit into
Conversation
VasilevNStas
force-pushed
the
1646-Integer-nil
branch
from
66099c8 to
89d5a8c
Compare
VasilevNStas
force-pushed
the
1646-Integer-nil
branch
from
89d5a8c to
2f2a8ac
Compare
Contributor
Author
|
@yegor256 plz review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1646
On
PullRequestReviewEvent, line 279 reads:If the PR author's GitHub account was deleted,
:useris nil andInteger(nil)raisesTypeError: can't convert nil into Integer. This crashes the judge mid-iteration and skips all remaining repos.Fix: use
&.to_iinstead ofInteger().nil&.to_ireturnsnil, andnil == fact.whoisfalse, so we don't skip and continue processing. Thepull-was-merged.rbcase (Integer(actor[:id])at line 115) is already guarded byif actoron line 117.