#565 Conclude#follow raises Fbe::Error on second call#572
Conversation
|
@yegor256 please review |
| # @param [Array<String>] props List of property names | ||
| # @return [nil] Nothing | ||
| def follow(props) | ||
| raise(Fbe::Error, 'Follow is already set') unless @follows.empty? |
There was a problem hiding this comment.
This behavior change ships without a test. Since #565 is specifically about the second call, a test that calls follow twice and asserts the second raises Fbe::Error (and that a single call still works) would lock in the new contract.
|
Good catch. Added |
|
@morphqdd Thanks for the review! You've earned +9 points for this: +18 as a basis; -5 for very few (1) comments; -4 for too few (1) hits-of-code. Your running score is +698; don't forget to check your Zerocracy account too). |
|
@VasilevNStas Thanks for the contribution! You've earned +20 points for this: +24 as a basis; -4 for too few (22) hits-of-code. Please, keep them coming. Your running score is +2000; don't forget to check your Zerocracy account too). |
Fixes #565
Conclude#follownow raisesFbe::Errorwhen called a second time, consistent withbyandasinFbe::Iterate.Previously it silently overwrote
@follows.