fix: request read_api OAuth scope when GITLAB_READ_ONLY_MODE is enabled#381
Merged
zereight merged 2 commits intozereight:mainfrom Mar 22, 2026
Merged
Conversation
When GITLAB_READ_ONLY_MODE=true, the OAuth flow still requested the full `api` scope, granting read/write access at the token level. The read-only restriction was only enforced at the MCP tool-filtering layer. This changes the requested OAuth scope to `read_api` when read-only mode is enabled, enforcing least-privilege at the GitLab token level as well. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jannahopp
force-pushed
the
fix/oauth-scope-read-only-mode
branch
from
c76a794 to
6103527
Compare
1. Replace Math.random() with crypto.randomUUID() for OAuth state parameters and request IDs — CSRF tokens must be cryptographically unpredictable. 2. HTML-encode the error query parameter in the OAuth callback page to prevent reflected XSS. 3. Redirect pino logger to stderr in oauth.ts to prevent JSON log lines from polluting the MCP stdio transport channel. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zereight
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Test plan