setCharset is a real method and so the doccomment is not required#698
setCharset is a real method and so the doccomment is not required#698bencromwell wants to merge 1 commit intozendframework:masterfrom
Conversation
`setCharset` is covered by a concrete implementation in the class and not part of the __call magic method. It therefore doesn't need the @method doccomment declaration. This change prevents IDEs such as PhpStorm from picking it up as an error.
|
@bencromwell
http://framework.zend.com/participate/contributor-guide-v1 You should think about a migration! ZF3 is around the corner and the support of ZF1 will end one day. |
|
@froschdesign thanks for the signposting. Will bear in mind! I've been slowly refactoring sections but it is a legacy project very tightly coupled in places! Is EOL expected? The last I saw was something from @weierophinney on Twitter suggesting if the community maintains it it would be able to continue. Apologies if I've got that wrong. |
I expect that we'll go to security fixes only at some point this year. |
|
@akrabat thanks for the heads up |
3 participants
setCharsetis covered by a concrete implementation in the class and not part of the __call magic method.It therefore doesn't need the @method doccomment declaration.
This change prevents IDEs such as PhpStorm from picking it up as an error.
Have sent in a CLA - I know this is a small change but we have a long-term ZF1 project at work so I anticipate more meaningful PRs in the future!