Use worktree environment for spawning the language server#24
Use worktree environment for spawning the language server#24MrSubidubi merged 3 commits intozed-extensions:mainfrom
Conversation
This also prefers any executable on PATH named bash-language-server.
|
We require contributors to sign our Contributor License Agreement, and we don't have @SKalt on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @SKalt on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this! Looks good, could you quickly elaborate as to why the language server needs the environment? Is it for the stuff at https://github.com/bash-lsp/bash-language-server/blob/c6b9bdac071a064bd697159e3da733adaf46ab33/server/src/config.ts#L82-L102?
Code-wise looks good, just would like to know the reasoning. Thanks!
|
The language server needs |
MrSubidubi
left a comment
There was a problem hiding this comment.
Makes sense, thank you for the context! One quesrtion and we should be good to go
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this and congratulations to your first contribution! 🎉
|
Well, the beauty of GitHub - should have worked earlier, but only now did after manual action.. Anyway, thanks, fix will soon roll out! |
This also prefers any executable on PATH named bash-language-server.
Fixes #2.