chore(examples): refresh longhorn example to v1.11.2#4923
chore(examples): refresh longhorn example to v1.11.2#4923acald-creator wants to merge 4 commits into
Conversation
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Hey @acald-creator thanks for the PR! Is this ready for a review? If so move it out of draft and we will take a look |
|
@AustinAbro321 ready for review |
|
@acald-creator did you get this to deploy successfully? I am trying locally and running into problems |
|
@AustinAbro321 let me take a look |
…try config Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
acald-creator
force-pushed
the
upgrade-longhorn
branch
from
b4ab1bb to
38139e1
Compare
|
@AustinAbro321 I tested deployment on kind and k3s, and it deployed successfully for me |
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
Thanks for taking this on! A few thoughts but otherwise I think the only thing we need to do is validate functionality.
- Package creates successfully
- Package deploys successfully (preferably offline but I can test that if you can't)
- Validate operational functionality (can we deploy a workload that has a persistent volume requirement)
| - source: https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux64 | ||
| target: jq | ||
| shasum: af986793a515d500ab2d35f8d2aecd656e764504b789b66d7e1a0b727a124c44 | ||
| - source: https://github.com/longhorn/cli/releases/download/v1.11.2/longhornctl-linux-amd64 |
There was a problem hiding this comment.
This script is indeed no longer available but introducing a binary will add a fair bit of complexity (IE this cannot be used with arm64 as written and making this architecture aware could be complex).
Two suggestions:
- Look at any "portable" solutions we might be able to leverage
- remove the environment check / longhornctl component entirely
For ease of update - I think it is valid to remove that component and document any prerequisites in the package documentation.
There was a problem hiding this comment.
I was thinking about that, I wanted to try it out and see how longhornctl would looks like, but I think that removing the component would be best and document any prerequisites.
I can look into your suggestions in the meantime.
| selector: [] | ||
| removeSnapshotsDuringFilesystemTrim: ignored # "enabled" or "disabled" otherwise | ||
|
|
||
| # Keep this file minimal so we inherit Longhorn chart defaults. |
There was a problem hiding this comment.
I tend to agree here in sentiment but the current capabiltiies of zarf dev|package inspect values-files do offer some capability to airgapped environments if we have re-specified the whole values file (or at least what is pertinent).
I'd lean towards maintaining the copy but feel free to push back.
There was a problem hiding this comment.
Thank you for your feedback, I am still learning Zarf, so I will look more into zarf's current capabilities, and look more into this.
…lti-arch support Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
… overrides Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
3 participants
Description
Updates the
examples/longhornpackage from the legacyv1.4.0setup to current Longhornv1.11.2, and replaces the old environment check script flow withlonghornctlpreflight checks.Changes
metadata.version->1.11.2charts[].version->1.11.2longhorn-environment-checkcomponent withlonghornctllonghornctlbinary from thev1.11.2releaseonDeployto run:./longhornctl check preflightimages:list for the updated chart/image setexamples/longhorn/values.yamlto minimal K3s override onlyValidation
Related Issue
Fixes #4875
Checklist before merging