OCIO generator improvements #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the OCIO config generator to support multiple displays and improve target view space handling. Introduces dedicated methods for managing displays, enhancing flexibility. Modifies how target view spaces are configured to handle both OCIO v1 and v2 configurations. Ensures proper display list and active display settings are set. Updates default data and working space.
Removes the `test` command from the available options displayed in the default function. This command is no longer needed or relevant.
Simplifies the assignment of display views within the OCIO configuration generator. It clarifies the logic for adding display views, removing redundant conditional checks based on OCIO config versions. The `addDisplayView` method arguments are now passed as named arguments.
iLLiCiTiT
reviewed
Nov 25, 2025
| """ | ||
| for arg in args: | ||
| if isinstance(arg, list): | ||
| self.append_displays(*arg) |
Member
There was a problem hiding this comment.
Why not just?
Suggested change
| self.append_displays(*arg) | |
| self._displays.extend(*arg) |
iLLiCiTiT
reviewed
Nov 25, 2025
| "--colorconfig", | ||
| self._dest_path, | ||
| (f'--ociolook:from="{self.working_space}"' f':to="{self.working_space}"'), | ||
| (f'--ociolook:from="{self.working_space}"' f':to="{self.data_space}"'), |
Member
There was a problem hiding this comment.
Suggested change
| (f'--ociolook:from="{self.working_space}"' f':to="{self.data_space}"'), | |
| f'--ociolook:from="{self.working_space}"' f':to="{self.data_space}"', |
iLLiCiTiT
reviewed
Nov 25, 2025
| self.data_space = data_space or "lin_ap0" | ||
| self.working_space = working_space or "lin_ap1" | ||
|
|
||
| if all([target_view, target_display]): |
Member
There was a problem hiding this comment.
Suggested change
| if all([target_view, target_display]): | |
| if target_view and target_display: |
Collaborator
|
just chiming in to say that the CI test here fail because our source for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Enhanced OCIO (OpenColorIO) configuration generator with improved color space management and display/view control. This update introduces separate data and working color space handling, adds granular display/view configuration options, and modernizes Python type annotations. The changes enable more precise color management workflows for VFX pipelines by separating linear AP0 data space from linear AP1 working space and providing better control over target displays and views.
Additional info
Key Technical Improvements:
data_space(default: lin_ap0) andworking_space(default: lin_ap1) for better ACES compliancetarget_displayandtarget_viewparameters allow precise control over OCIO display configurationstarget_colorspaceparameterset_displays(),append_displays(), andclear_displays()methods for programmatic display controlOptional[type]totype | NonePython 3.10+ syntaxThe refactoring maintains backward compatibility while providing more granular control over color pipeline configuration, essential for modern VFX workflows requiring ACES-compliant color management.
Testing notes:
target_displayandtarget_viewparameterstarget_colorspacefallback when display/view pairs are not specifiedset_displays,append_displays) for programmatic control