Skip to content

Fixed fatal bug where model failed to save #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ADKoishi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed fatal bug where model failed to save #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800dabd
Fixed fatal bug where model failed to save
ADKoishi Jan 17, 2024
bbb8245
Fixed saving failure with bf16 AMP.
ADKoishi Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/train_with_rm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ def compare(a, b):
# this is a hack to force wandb to log the images as JPEGs instead of PNGs
with tempfile.TemporaryDirectory() as tmpdir:
for i, image in enumerate(images):
pil = Image.fromarray((image[0].cpu().numpy().transpose(1, 2, 0) * 255).astype(np.uint8))
image_np = image[0].to('cpu').to(torch.float32).numpy()
pil = Image.fromarray((image_np.transpose(1, 2, 0) * 255).astype(np.uint8))
pil = pil.resize((256, 256))
pil.save(os.path.join(tmpdir, f"{i}.jpg"))
accelerator.log(
Expand Down Expand Up @@ -572,7 +573,7 @@ def compare(a, b):
# make sure we did an optimization step at the end of the inner epoch
assert accelerator.sync_gradients

if epoch!=0 and (epoch+1) % config.save_freq == 0 and accelerator.is_main_process:
if epoch!=0 and (epoch+1) % config.save_freq == 0:
accelerator.save_state()


Expand Down