[codex] Add ignored app controls - #23
Merged
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
July 18, 2026 06:57
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TypeSwitch previously had no complete way to exclude an application from management. An app using the default strategy still inherited the global fallback, so users could not prevent automatic switching for selected apps. Those apps also continued to occupy the current, running, configured, unavailable, and statistics menus even when the user did not want TypeSwitch to manage or display them.
Root cause and user impact
The rule model only distinguished inherited, fixed, and remember-last input method behavior. It did not have a persistent ignored state or a recovery surface. Adding a simple no-switch branch alone would stop switching, but it would still leave ignored apps visible and could make menu contents mutate while an open native menu was being used.
Fix
This change adds an
ignoredinput method strategy. Ignored apps skip input method lookup and switching, do not increment statistics, and are filtered from all regular app and statistics lists. A newIgnored Appsmenu provides individual restore and restore-all actions; restoring returns the app to the default inherited strategy.The menu bar app now snapshots app strategies while the root
NSMenuis tracking. Ignore and restore operations are persisted immediately, while visible menu membership remains stable until the menu closes. Unavailable ignored rules are preserved by cleanup, and ignoring an unavailable app retains its last known path.The change also adds Base, English, Simplified Chinese, and Traditional Chinese copy, updates both READMEs, and refreshes all deterministic raw and composite screenshots to show the new controls.
Validation
rtk just checkrtk proxy ./script/validate_readme_screenshots.shrtk git diff --checkignoredround trips and existing strategy decoding