[codex] Harden release provenance and login rollback - #37
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
July 25, 2026 03:55
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change hardens release provenance and makes LaunchAgent fallback updates recoverable when installation fails.
The release workflow previously allowed a manually dispatched run to publish an existing tag while the checked-out source still came from the dispatch branch. That could attach an artifact, Sparkle metadata, and a valid GitHub Artifact Attestation to a release tag whose commit did not produce the binary. Manual retries also needed an explicit path that GitHub's branch-only web UI could not provide.
The LaunchAgent fallback installer staged a new plist before committing it, but a failed replacement could delete the previously working plist. A transient filesystem or
launchctlfailure could therefore turn an existing launch-at-login setup into a disabled one.Changes
User impact
Release artifacts can no longer be silently built from a branch and published under a different tag. Operators receive an early, actionable failure when the dispatch ref is wrong and can verify the final artifact against the exact tag provenance.
Users with an existing fallback login item no longer lose that configuration when an attempted update fails. The previous plist remains available for the next login even if immediate recovery bootstrap also fails.
Validation
rtk just checkgit diff --checkactionlint .github/workflows/release.yml(only the pre-existing SC2129 style warning andsoftprops/action-gh-release@v1runner warning remain)gh workflow run --refaccepts a branch or tag and-fsupplies therelease_taginput