[codex] Align release security - #36
Merged
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
July 24, 2026 07:12
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 similar comment
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ListenBar's release workflow regenerated the entire Homebrew cask on every release. The Homebrew tap now owns a custom
postflightstep that removes the quarantine attribute after installation, together with explicit unsigned and notarization caveats. A subsequent ListenBar release would have replaced those tap-managed sections with the older cask template.The release zip also had SHA-256 and Sparkle EdDSA protection but no GitHub Artifact Attestation, and the project READMEs did not explain the different trust boundaries for Homebrew and manual downloads.
User impact
Without this change, a new release could silently remove the Homebrew quarantine handling and restore outdated installation guidance. Users would also lack a repository-backed provenance check for newly published release zips.
Root cause
The workflow treated the full Homebrew cask as generated output even though installation policy is maintained in
ygsgdbd/homebrew-tap. This duplicated the cask definition across repositories and allowed the release automation to overwrite unrelated tap changes.Changes
actions/attest@v4and attest onlyListenBar-macOS-universal.zipbefore publishing the GitHub Release.version,sha256, andurlfields.postflight,caveats,uninstall, andzapcontent.brew trustauthorizes the third-party cask, while the cask's custompostflightremoves quarantine without signing or notarizing ListenBar.v0.4.0and earlier releases do not have attestations.Validation
rtk just checkactionlintfor the changed workflow configuration, excluding the existingSC2129andsoftprops/action-gh-release@v1baseline findingsrtk git diff --checkversion,sha256, andurlchange, tap-managed content remains intact, and a missing release field aborts the update