[codex] Harden core reliability - #35
Merged
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
July 23, 2026 08:56
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens ListenBar's two core reliability paths: collecting listener data from
lsofand maintaining the fallback LaunchAgent used for launch at login. It also updates the product roadmap with the current feature priorities and enables XCTest timeouts for the new process stress tests.Problem and user impact
The port scanner previously waited for the child process to exit before draining stdout and stderr. A child that produced enough output could fill either pipe and block forever, leaving ListenBar's refresh stuck. The scanner could also accept parseable stdout from a non-zero
lsofexit and publish an incomplete snapshot.The fallback login-item path wrote its final plist before
launchctl bootstrapcompleted. If bootstrap failed, the remaining plist could make the app report launch at login as enabled even though the service had not loaded. Similar ambiguity existed when committing a staged plist failed.Root cause
Process termination and pipe consumption were sequenced instead of coordinated concurrently, and the
lsofparser treated usable output as success without first requiring a zero exit status. The LaunchAgent installation was not transactional: its status marker was visible before service registration succeeded, and rollback did not consistently separate staging artifacts from the committed plist.Changes
DispatchIOwhile awaiting process termination asynchronously.lsofexits before parsing stdout, while retaining the existing status-code fallback message.gui/<uid>/<label>service target forbootoutand clean up staged and committed artifacts on failed installation.ROADMAP.md.ROADMAP.mdto reflect implemented ignored-process controls and the current priorities for watched ports, history, diagnostics, manual refresh, and automation integrations.Validation
rtk just checkrtk git diff --check